Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Each contract should have a separate rollback batch #397

Open
Tadeuchi opened this issue Apr 20, 2023 · 0 comments
Open

[BUG] Each contract should have a separate rollback batch #397

Tadeuchi opened this issue Apr 20, 2023 · 0 comments
Assignees
Labels
bug Something isn't working x-files

Comments

@Tadeuchi
Copy link
Contributor

There is one SortKeyCache instance for reading/writing contract state cache.
As ppe pointed out this means that the rollback batch is shared among all contract cache.
In case of a very unfortunate events order this may cause some incorrect rollback/commit behaviour??

Since now we do not perform any rollbacks on the state cache this seems not be a problem, at least for now...
Warp evolves very fast and it is very important to keep that issue mind and maybe change the rollback implementation to a map
Map<tx_id, rollbackBatch>

Related to
warp-contracts/warp-contracts-lmdb#24 (comment)

@Tadeuchi Tadeuchi added the bug Something isn't working label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working x-files
Projects
None yet
Development

No branches or pull requests

2 participants