Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant arguments from simulation_options #339

Open
djps opened this issue Mar 5, 2024 · 1 comment
Open

Remove redundant arguments from simulation_options #339

djps opened this issue Mar 5, 2024 · 1 comment
Assignees
@djps
Milestone
v0.3.4

Comments

@djps
Copy link
Collaborator

djps commented Mar 5, 2024

Describe the change

  • Streamline code by reducing the number of redundant options in simulation_options call as pml_x_size
  • Extend pml_alpha to take values which can lead to different values in different directions
@djps djps self-assigned this Mar 5, 2024
@waltsims waltsims modified the milestones: v0.3.4, v0.3.3 Apr 16, 2024
@waltsims
Copy link
Owner

This would need deprication warnings with planned deprication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djps djps

Labels
None yet
Projects
None yet
Milestone
v0.3.4
Development

No branches or pull requests
2 participants
@djps @waltsims