Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_cast as numpy dtype #338

Open
djps opened this issue Mar 5, 2024 · 4 comments
Open

data_cast as numpy dtype #338

djps opened this issue Mar 5, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@djps
Copy link
Collaborator

djps commented Mar 5, 2024

Describe the bug
Makes sense to refactor parts of simulation_options so that the data_cast option is a numpy type rather than a string

@djps djps added the bug Something isn't working label Mar 5, 2024
@djps djps changed the title [BUG] data_cast as numpy dtype data_cast as numpy dtype Mar 5, 2024
@djps djps self-assigned this Mar 5, 2024
@djps djps removed the bug Something isn't working label Mar 5, 2024
@waltsims waltsims added the enhancement New feature or request label Mar 19, 2024
@waltsims
Copy link
Owner

@djps can you better describe what the current behavior is and what enhancement is needed?

@djps
Copy link
Collaborator Author

djps commented Apr 1, 2024

In simulation_options the argument data_cast is either either off, single or double.

I think setting a default as np.float64 with another accepted option being np.float32.

@waltsims
Copy link
Owner

waltsims commented Apr 2, 2024

Currently in save_h5_file all values are cast to float32 here. We can continue to look into this behavior and try to ensure that precision is taken into account.

@djps
Copy link
Collaborator Author

djps commented Apr 2, 2024

Seems to replicate the matlab behaviour in writeMatrix

@waltsims waltsims self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants