Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend HDF5 compression options #236

Open
djps opened this issue Dec 21, 2023 · 1 comment · May be fixed by #332
Open

Extend HDF5 compression options #236

djps opened this issue Dec 21, 2023 · 1 comment · May be fixed by #332
Assignees
@djps
Labels
enhancement New feature or request
Milestone
v0.3.4

Comments

@djps
Copy link
Collaborator

djps commented Dec 21, 2023

Is your feature request related to a problem? Please describe.
The hdf_compression_level: Optional[int] should also except a number of strings so that other compression algorithms supported by h5py can be used, such as lzf

Describe the solution you'd like
Ensure the proper arguments can be passed.
@djps djps added the enhancement New feature or request label Dec 21, 2023
@waltsims
Copy link
Owner

It might make sense to make the argument an enum to be able to type the options. Also this would prevent the int/string type mixing.

@djps djps self-assigned this Jan 21, 2024
@waltsims waltsims added this to the v0.3.2 milestone Jan 25, 2024
@djps djps linked a pull request Feb 27, 2024 that will close this issue
Open
@waltsims waltsims modified the milestones: v0.3.2, v0.3.3 Feb 27, 2024
@waltsims waltsims modified the milestones: v0.3.3, v0.3.4 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djps djps

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.4
Development

Successfully merging a pull request may close this issue.

Extend HDF5 compression options djps/k-wave-python
2 participants
@djps @waltsims