Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor clean_and_read text usage #6

Open
walshbr opened this issue Jan 20, 2015 · 0 comments
Open

Refactor clean_and_read text usage #6

walshbr opened this issue Jan 20, 2015 · 0 comments

Comments

@walshbr
Copy link
Owner

walshbr commented Jan 20, 2015

Some functions take in a file name. Some take in a processed file. This is causing some confusion (mostly for me as I code), where some functions break when they take the wrong type of argument. I should really organize the thing better so that it only happens in one place. Or organize the functions better so that it's clear what is what.

walshbr added a commit that referenced this issue Jan 26, 2015
…it's something just needs to be done at the beginning, prior to anything else. Not 100% sure I did it right for the vectorizer report and whatnot. It's still working, but need to look at Eric's code a bit more closely to see if it's taking in processed text vs file paths and where it is doing so. Refs #6.
walshbr added a commit that referenced this issue Mar 18, 2017
…it's something just needs to be done at the beginning, prior to anything else. Not 100% sure I did it right for the vectorizer report and whatnot. It's still working, but need to look at Eric's code a bit more closely to see if it's taking in processed text vs file paths and where it is doing so. Refs #6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant