Replies: 3 comments
-
The rewrite would also help third-party applications like the Android one as there's no easy way to clean up removed/unused tags without a full resync. |
Beta Was this translation helpful? Give feedback.
-
Here are some thoughts I had recently on tags: I agree with the need to update the database model to actually attach tag entities to users, it would simplify housekeeping and code a lot imo. It should be noted that this may not completely fix the performance issue that can be seen on wallabag.it, there may be another refacto needed here. Having tags associated to users would let them do several new things:
|
Beta Was this translation helpful? Give feedback.
-
I'm all in for that too. The new schema looks ok to me. Or maybe we need a different solution about URL, maybe using the database id instead? |
Beta Was this translation helpful? Give feedback.
-
Today, our tags system is really not perfect.
Today
Here is the database model:
Tables
wallabag_tag
The table used to store tags.
wallabag_entry
The table used to store entries.
wallabag_entry_tag
The table used for the relation between a tag and an entry.
Main problem
The tags aren’t user-related.
It can cause performance issues.
One example on app.wallabag.it for the tag
politics
: there are 46.122 entries with this tag. So, each time a user want to add / remove this tag from an entry, we embed too much entries. There is an issue for this bug: #4998Tomorrow
Update database schema
wallabag_tag
wallabag_entry
wallabag_entry_tag
Migrations
We have to update
wallabag_tag
to add a relation to thewallabag_user
table.Then, we have to update the existing content.
For each tag, we have to update the new
user_id
field with theuser_id
of the related entry.Bugs related to tags
Here are the issues which won’t be fixed until we update the database schema (feel free to link other issues related to tags in comments below):
We also have features requests related to tag (autocompletion for example).
I think that these features should be implemented only when we’ll do the tags handling rewrite.
Feel free to participate to this rewrite
The “Tomorrow” section is only my first idea to improve the tags handling. Feel free to comment if you have other ideas 👇
Beta Was this translation helpful? Give feedback.
All reactions