Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add unit tests via the testthat package #468

Open
philiporlando opened this issue Aug 6, 2022 · 2 comments
Open

[Feature Request] Add unit tests via the testthat package #468

philiporlando opened this issue Aug 6, 2022 · 2 comments

Comments

@philiporlando
Copy link

Please correct me if I'm wrong, but it appears that this package has not incorporated any automated unit testing via the testthat package. Are unit tests being performed using a different method within this package? If so, please let me know so I can incorporate them into my development workflow on my forked version of this repo. If not, are there any plans to add unit testing in future releases?

@walkerke
Copy link
Owner

walkerke commented Aug 6, 2022

A test suite would be great; @mfherman and I discussed this a while back here: #83 (comment). If there is anyone in the user community interested in making this contribution to the package, it would be an excellent addition. The big thing to be mindful of is handling the tests with respect to how CRAN tests the package; this presents more of a challenge with API packages.

@philiporlando
Copy link
Author

Thank you for providing this info. I have some package development experience, but I have not worked with API packages before. Admittedly, incorporating unit tests into tidycensus appears to be a lot more involved than simply embracing a testthat worfklow. That being said, I'll do more research on this topic and if I come up with anything worthwhile then I'll be sure to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants