Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: wakunode Start() should make sure that the node is really started. #1095

Closed
richard-ramos opened this issue Apr 30, 2024 · 3 comments

Comments

@richard-ramos
Copy link
Member

See for context.
status-im/status-go#4969 (comment)

It seems that adding a time.Sleep after the node starts tends to fix the issue, otherwise we might get a ErrNoAddresses from a node that tries to connect to a separate node that is started but not really available.

@chaitanyaprem
Copy link
Collaborator

chaitanyaprem commented May 2, 2024

Node Start just means the local node has started with all services up. It doesn't have to ensure the local node is connected to a peer. I think the ErrNoAddresses was occuring because of a dial to the peer(which hasn't probably finished identify).

I have gone through the Start of Wakunode2 and i don't see anything that is pending by the time we return apart from things that are supposed to happen async anyways.

@chaitanyaprem
Copy link
Collaborator

I don't think this is an issue @richard-ramos . Can we close this?

or do add some more context.

@richard-ramos
Copy link
Member Author

Ah! i had missed these messages. Sorry for the delay.
Yeah, I went over it and the solution used by @qfrank in the end and i think this is a non issue. It seems that the test case relied in discv5 to connect to each other, but that can fail as seen in the status-go issue. I see the solution used does a dial to the node, and that for sure solved the problem since the nodes were connected to each other before the logic for the test was executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants