Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content Author Module 2: Structure] [ED-med] Unclear rewrite #657

Open
iadawn opened this issue Sep 20, 2022 · 2 comments
Open

[Content Author Module 2: Structure] [ED-med] Unclear rewrite #657

iadawn opened this issue Sep 20, 2022 · 2 comments
Labels
done Done. Will close when related PRs are merged.

Comments

@iadawn
Copy link

iadawn commented Sep 20, 2022

In the 'Headings' topic a learning outcome has been changed to:

describe the accessibility considerations when changing the default visual appearance of headings, including the potential inaccessibility of:

  • the selected custom visual appearance
  • the generated markup

I am not sure what this means. I am guessing the first part is "if you change the styling, make it accessible" and the second part might be "use heading elements". It seems a bit vague though. Particularly the latter point, if I am guessing correctly, could be much clearer.

@iadawn iadawn changed the title [Module 2: Structure] [ED-med] Unclear rewrite [Content Author Module 2: Structure] [ED-med] Unclear rewrite Sep 20, 2022
@daniel-montalvo
Copy link
Collaborator

Thanks @iadawn

That's precisely what all of this is about.

But you are right that this is getting too much into detail probably.

What about

describe the characteristics of accessible headings, including text, visual appearance, and markup

Which reinforces the idea that accessible headings are not just about visual appearance, but also about good markup

@daniel-montalvo daniel-montalvo added the question Further information is requested label Sep 21, 2022
@iadawn
Copy link
Author

iadawn commented Sep 22, 2022

Happy with that suggested change.

@daniel-montalvo daniel-montalvo added done Done. Will close when related PRs are merged. and removed question Further information is requested labels Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Done. Will close when related PRs are merged.
Projects
None yet
Development

No branches or pull requests

2 participants