Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC-JWT examples are out-of-date #1485

Open
vincentkelleher opened this issue May 6, 2024 · 3 comments
Open

VC-JWT examples are out-of-date #1485

vincentkelleher opened this issue May 6, 2024 · 3 comments
Assignees
Labels
CR1 This item was processed during CR1 editorial Purely editorial changes to the specification.

Comments

@vincentkelleher
Copy link

Hi again 👋

While reading the Verifiable Credentials Data Model v2.0 specification and the Securing Verifiable Credentials using JOSE and COSE specification, I've noticed discrepancies about VC-JWT encoding.

If I understand well (after reading some issues, discussions and PRs) the latter specification is the new reference for VC-JWT encoding. It states the following sentence in the JOSE Header and JWT Claims part:

The JWT Claim Names vc and vp MUST NOT be present.

Looking at Example 3 of the VC Data Model v2.0 specification, I noticed that the vc claim is used.

image

I imagine this is an outdated example ? If so, here are the parts of the specification that need to be updated:

@msporny
Copy link
Member

msporny commented May 27, 2024

Yes, we need to fix this. We finally updated the version of respec-vc to use the new code base, we need to update the vc-jose-cose portions of that code base now.

@msporny msporny added editorial Purely editorial changes to the specification. CR1 This item was processed during CR1 labels May 27, 2024
@decentralgabe decentralgabe self-assigned this May 29, 2024
@decentralgabe
Copy link
Contributor

I will take an action to update respec-vc.

@iherman
Copy link
Member

iherman commented May 29, 2024

The issue was discussed in a meeting on 2024-05-29

  • no resolutions were taken
View the transcript

5.3. VC-JWT examples are out-of-date (issue vc-data-model#1485)

See github issue vc-data-model#1485.

Brent Zundel: VC JWT examples are out of date.

Manu Sporny: good news is we released a new version of respec-vc.
… but the new jose/cose stuff is not in there yet.
… it should be a copy/paste into respec-vc.
… or decentralgabe can send a PR there.

Gabe Cohen: it's on my list.
… and given the update to remove YAML from the jose/cose spec, it should be simpler to do now.

Manu Sporny: just to make sure we're aligned, what are you planning to implement?
… SD-JWT, JOSE, COSE, something else?

Gabe Cohen: I was going to do all 3, but not automatically render them.
… I'll put up a PR.
… I'd prefer to start by fixing what is currently labelled VC-JWT.

Manu Sporny: you can pick which tabs to show per example.

Brent Zundel: with that, we are out of time.
… great consensus building. we love our volunteers.
… bye for now.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during CR1 editorial Purely editorial changes to the specification.
Projects
None yet
Development

No branches or pull requests

6 participants