Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnvelopedVerifiablePresentation missing in https://www.w3.org/ns/credentials/v2 #1482

Closed
vincentkelleher opened this issue May 2, 2024 · 3 comments
Closed

EnvelopedVerifiablePresentation missing in https://www.w3.org/ns/credentials/v2 #1482

vincentkelleher opened this issue May 2, 2024 · 3 comments
Assignees
@msporny
Labels
CR1 This item was processed during CR1 editorial Purely editorial changes to the specification. pr exists

Comments

@vincentkelleher
Copy link

vincentkelleher commented May 2, 2024 •
edited

Hi 馃憢

We have noticed that the EnvelopedVerifiablePresentation term is missing in the https://www.w3.org/ns/credentials/v2 context although it has been added to the specification through #1431 and is mentioned here.

Are we missing something or a fix is needed ?

Thanks for your help 馃槉
@msporny msporny self-assigned this May 6, 2024
@msporny msporny added editorial Purely editorial changes to the specification. CR1 This item was processed during CR1 labels May 6, 2024
@msporny
Copy link
Member

msporny commented May 6, 2024

Are we missing something or a fix is needed ?

Good catch, a fix is needed, we'll make the fix. Thank you for finding that bug!

@msporny msporny added the ready for PR This issue is ready for a Pull Request to be created to resolve it label May 6, 2024
@vincentkelleher
Copy link
Author

Thanks for all the good work @msporny 馃檹

@msporny
Copy link
Member

msporny commented May 27, 2024

Fixed in 1826543. Closing.

@msporny msporny closed this as completed May 27, 2024
@msporny msporny added pr exists and removed ready for PR This issue is ready for a Pull Request to be created to resolve it labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
CR1 This item was processed during CR1 editorial Purely editorial changes to the specification. pr exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msporny @vincentkelleher