Ensure spec PR's diffs are generated correctly

[mbrodesser-Igalia]

See #450 (comment).

[koto]

I traced where the spurious diff changes are coming from. Bikeshed generates IDs for term references for the definition panels using "circled digits" (id="ref-for-trusted-types-sink-group②). The circled digits are just sequential numbers, so if a PR refers to a term, or stops to referring to it, all subsequent links of that term will have different IDs, and will surface in a diff.

Unfortunately, I don't think this can be changed. Setting Use Dfn Panels to false still makes Bikeshed generate the IDs, and the actual diff engine doesn't have any relevant configuration. I'm not sure anything can be done about it, short of writing a new postprocessor and registering it with pr-preview.

[mbrodesser-Igalia]

I traced where the spurious diff changes are coming from. Bikeshed generates IDs for term references for the definition panels using "circled digits" (id="ref-for-trusted-types-sink-group②). The circled digits are just sequential numbers, so if a PR refers to a term, or stops to referring to it, all subsequent links of that term will have different IDs, and will surface in a diff.

Unfortunately, I don't think this can be changed. Setting Use Dfn Panels to false still makes Bikeshed generate the IDs, and the actual diff engine doesn't have any relevant configuration. I'm not sure anything can be done about it, short of writing a new postprocessor and registering it with pr-preview.

CC @domenic given your experience with writing specs, did you stumble over that and can recommend a fix?

[domenic]

I don't really use the diffs, sorry.

[mbrodesser-Igalia]

Unfortunately the diffs still aren't correct. See e.g. #477.

@annevk: are you familiar with this issue and can recommend a fix, or someone who can?

[annevk]

You could try patching https://github.com/w3c/htmldiff-ui but I'd recommend just skipping past the noise.

(In particular, to do a thorough review you need to look at the source changes so you can use those as a guide as to what constitutes noise.)