Support non-"fully active" documents #415

anssiko · 2021-09-22T12:36:02Z

We should check that the spec complies with https://w3ctag.github.io/design-principles/#support-non-fully-active

Given https://w3c.github.io/sensors/#can-expose-sensor-readings is conditional to https://html.spec.whatwg.org/multipage/interaction.html#currently-focused-area-of-a-top-level-browsing-context (among other checks) we may be good.

@marcoscaceres is probably interested in this design discussion.

…active. When a sensor is created on e.g. an iframe that is later removed from its parent via removeChild(), we end up in a situation where a sensor instance did get created but which does not have a valid ExecutionContext by the time start() is invoked. Check for a valid ExecutionContext when start() is called and bail out early if it is null. w3c/sensors#415 tracks handling non-fully active documents from a spec perspective; once that one is fixed we should probably throw an error in this case rather than silently doing nothing. Bug: 1289924 Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2

…active. When a sensor is created on e.g. an iframe that is later removed from its parent via removeChild(), we end up in a situation where a sensor instance did get created but which does not have a valid ExecutionContext by the time start() is invoked. Check for a valid ExecutionContext when start() is called and bail out early if it is null. w3c/sensors#415 tracks handling non-fully active documents from a spec perspective; once that one is fixed we should probably throw an error in this case rather than silently doing nothing. Bug: 1289924 Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412476 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/main@{#962930}

…active. When a sensor is created on e.g. an iframe that is later removed from its parent via removeChild(), we end up in a situation where a sensor instance did get created but which does not have a valid ExecutionContext by the time start() is invoked. Check for a valid ExecutionContext when start() is called and bail out early if it is null. w3c/sensors#415 tracks handling non-fully active documents from a spec perspective; once that one is fixed we should probably throw an error in this case rather than silently doing nothing. Bug: 1289924 Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412476 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/main@{#962930}

…active. When a sensor is created on e.g. an iframe that is later removed from its parent via removeChild(), we end up in a situation where a sensor instance did get created but which does not have a valid ExecutionContext by the time start() is invoked. Check for a valid ExecutionContext when start() is called and bail out early if it is null. w3c/sensors#415 tracks handling non-fully active documents from a spec perspective; once that one is fixed we should probably throw an error in this case rather than silently doing nothing. Bug: 1289924 Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412476 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/main@{#962930}

rakuco · 2022-01-25T16:35:33Z

For the record: I've recently landed a patch in Chromium that makes Sensor.start() do nothing when the document is not fully active (strictly speaking, when there's no attached frame i.e. there's no browsing context). At least that part of the spec should be updated to take this into consideration at some point.

…en the document is not fully active., a=testonly Automatic update from web-platform-tests sensors: Do nothing in Sensor.start() when the document is not fully active. When a sensor is created on e.g. an iframe that is later removed from its parent via removeChild(), we end up in a situation where a sensor instance did get created but which does not have a valid ExecutionContext by the time start() is invoked. Check for a valid ExecutionContext when start() is called and bail out early if it is null. w3c/sensors#415 tracks handling non-fully active documents from a spec perspective; once that one is fixed we should probably throw an error in this case rather than silently doing nothing. Bug: 1289924 Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412476 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/main@{#962930} -- wpt-commits: 57fbbb2179141a672ee861ba53d9afb705bdb7f8 wpt-pr: 32514

…active. When a sensor is created on e.g. an iframe that is later removed from its parent via removeChild(), we end up in a situation where a sensor instance did get created but which does not have a valid ExecutionContext by the time start() is invoked. Check for a valid ExecutionContext when start() is called and bail out early if it is null. w3c/sensors#415 tracks handling non-fully active documents from a spec perspective; once that one is fixed we should probably throw an error in this case rather than silently doing nothing. (cherry picked from commit b93b733) Bug: 1289924 Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412476 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Cr-Original-Commit-Position: refs/heads/main@{#962930} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3423905 Auto-Submit: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4844@{chromium#104} Cr-Branched-From: 007241c-refs/heads/main@{#961656}

…active. When a sensor is created on e.g. an iframe that is later removed from its parent via removeChild(), we end up in a situation where a sensor instance did get created but which does not have a valid ExecutionContext by the time start() is invoked. Check for a valid ExecutionContext when start() is called and bail out early if it is null. w3c/sensors#415 tracks handling non-fully active documents from a spec perspective; once that one is fixed we should probably throw an error in this case rather than silently doing nothing. Bug: 1289924 Change-Id: I2b033252d93347ba7c91385bdb510b69b8298aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3412476 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/main@{#962930} NOKEYCHECK=True GitOrigin-RevId: b93b733b928610c36c328a4685c2129ed8a80e7b

anssiko mentioned this issue Sep 22, 2021

Devices and Sensors WG - TPAC 2021 agenda w3c/devicesensors-wg#47

Closed

chromium-wpt-export-bot mentioned this issue Jan 24, 2022

sensors: Do nothing in Sensor.start() when the document is not fully active. web-platform-tests/wpt#32514

Merged

rakuco mentioned this issue May 5, 2022

Unloading of workers (and hence Platform Collector) w3c/compute-pressure#104

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support non-"fully active" documents #415

Support non-"fully active" documents #415

anssiko commented Sep 22, 2021

rakuco commented Jan 25, 2022

Support non-"fully active" documents #415

Support non-"fully active" documents #415

Comments

anssiko commented Sep 22, 2021

rakuco commented Jan 25, 2022