Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if sandboxing flag check can move to the PresentationRequest ctor #379

Closed
mfoltzgoogle opened this issue Nov 29, 2016 · 3 comments

Comments

@mfoltzgoogle
Copy link
Contributor

Follow-up from Issue #362. It may be possible to check the sandboxing flag in the ctor for PresentationRequest, and this would simplify the algorithms that check it on function invocation.

However, if the attribute is dynamic or set on navigation, it may not be possible.

@mounirlamouri can you update this with what you discover in Blink?

@mounirlamouri
Copy link
Member

Looking at Blink code, it seems to be dynamic. My understanding of the spec is that it's not.

@annevk do I misinterpret the spec?

@annevk
Copy link
Member

annevk commented Nov 30, 2016

I don't really understand the sandboxing setup. Too much forwarding of state.

@mfoltzgoogle
Copy link
Contributor Author

Well, it would be safest to check it in both the PresentationRequest ctor and its functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants