Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PresentationSession to PresentationController #171

Closed
avayvod opened this issue Aug 24, 2015 · 7 comments
Closed

Rename PresentationSession to PresentationController #171

avayvod opened this issue Aug 24, 2015 · 7 comments
Labels

Comments

@avayvod
Copy link
Contributor

avayvod commented Aug 24, 2015

Based on https://lists.w3.org/Archives/Public/public-secondscreen/2015Aug/0027.html
Seems like renaming to PresentationController is the best way, where close() would close the presentation and an added disconnect() would detach the controller from the presentation.

@avayvod avayvod added the P1 label Aug 24, 2015
@mounirlamouri
Copy link
Member

FWIW, @sicking suggested PresentationConnection in the thread.

@avayvod
Copy link
Contributor Author

avayvod commented Aug 24, 2015

As I understand, it depends on issue #35:

  • if the api is close() to shut down presentation and disconnect() for disconnecting from it, PresentationController makes more sense (so one closes presentation via controller and disconnects the controller from it, PresentationConnection.close() would be confusing and disconnect() would sound redundant);
  • if the api is close() for disconnecting and end()/stop() for actually terminating the presentation, PresentationConnection makes more sense.

Since we already have close() that means tearing down the presentation, disconnect() seems an easier path to achieve what we want, therefore PresentationController is my choice. Jonas didn't seem to have a strong opinion.

@mfoltzgoogle
Copy link
Contributor

I agree with @avayvod's point of view on this. Let's close #35 and use the result to decide this.

@sicking
Copy link

sicking commented Sep 1, 2015

One issue is that this interface lives on both the presentation and the controller side. Something like PresentationController sounds to me like an object that only represents the controller side. In that regard PresentationSession or PresentationConnection is IMHO better.

I agree that it probably makes sense to make the final decision here once #35 is resolved.

@mfoltzgoogle
Copy link
Contributor

@avayvod given that we have .close() for disconnecting and .terminate() for stopping presentation, the argument here lands us at PresentationConnection. Do you agree?

@avayvod
Copy link
Contributor Author

avayvod commented Sep 15, 2015

Yep. SGTM

@mfoltzgoogle
Copy link
Contributor

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants