New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename PresentationSession to PresentationController #171
Comments
FWIW, @sicking suggested PresentationConnection in the thread. |
As I understand, it depends on issue #35:
Since we already have close() that means tearing down the presentation, disconnect() seems an easier path to achieve what we want, therefore PresentationController is my choice. Jonas didn't seem to have a strong opinion. |
One issue is that this interface lives on both the presentation and the controller side. Something like I agree that it probably makes sense to make the final decision here once #35 is resolved. |
@avayvod given that we have |
Yep. SGTM |
SGTM |
Based on https://lists.w3.org/Archives/Public/public-secondscreen/2015Aug/0027.html
Seems like renaming to PresentationController is the best way, where close() would close the presentation and an added disconnect() would detach the controller from the presentation.
The text was updated successfully, but these errors were encountered: