Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support #848

Closed
calidion opened this issue Feb 5, 2020 · 5 comments
Closed

i18n support #848

calidion opened this issue Feb 5, 2020 · 5 comments
Labels
Feature Request i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response.

Comments

@calidion
Copy link

calidion commented Feb 5, 2020

currently manifest only support a string for key name and short_name.

I would like to suggest, they use i18n based object to represent i18n strings.

for example:

from

{
name: "An Angular Based Application"
short_name: "angular"
}

to

{
name:  {
"en" : "An Angular Based Application",
"zh" : "一个基于角度的程序",
"ja" : "角度ベースのアプリケーション",
},
short_name: {
"en" : "Angular",
"zh" : "角度",
"ja" : "角度",
}
}
@fallaciousreasoning fallaciousreasoning added the i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. label Feb 6, 2020
@fallaciousreasoning
Copy link
Collaborator

I believe there was some discussion about doing something like this, but I can't find it in any of the other issues.

Related:
#323 #334 #335 #336 #337

From the sounds of things, the resolution on those issues was to serve a different manifest based on the Accept-Language? I guess that doesn't work for changing the language on the OS though.

@fallaciousreasoning
Copy link
Collaborator

Ah, I think this was the issue I wanted: #208

This idea, along with some others are discussed a bit there. The resolution seemed to be "Let's wait for a bit and see what problems come up", so I'll leave this open.

@fallaciousreasoning
Copy link
Collaborator

Note #211 is almost identical.

@calidion
Copy link
Author

calidion commented Feb 6, 2020

default_locale or languages is not necessary for the locale devices has defined their locales.
make all strings i18ned.

@r12a r12a added i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. and removed i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. labels Feb 13, 2020
@kenchris kenchris added Defer Until after REC Feature Request labels May 25, 2020
@marcoscaceres marcoscaceres removed the Defer Until after REC label May 31, 2022
@marcoscaceres
Copy link
Member

closing as duplicate of #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response.
Projects
None yet
Development

No branches or pull requests

5 participants