Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No language/direction metadata for shortcuts? #1078

Open
aphillips opened this issue May 15, 2023 · 4 comments
Open

No language/direction metadata for shortcuts? #1078

aphillips opened this issue May 15, 2023 · 4 comments
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.

Comments

@aphillips
Copy link

1.1.4 Creating shortcuts
https://w3c.github.io/manifest/#creating-shortcuts

Multiple examples are provided of creating a "shortcut" in a manifest. Here is one such:

  "shortcuts": [
    {
      "name": "Play Later",
      "description": "View the list of podcasts you saved for later",
      "url": "/play-later",
      "icons": [
        {
          "src": "/icons/play-later.svg",
          "type": "image/svg+xml"
        }
      ]
    },

The name and description fields do not have their own lang and dir values nor does the "shortcut" structure have the ability to provide an override. The whole manifest does have a lang and dir, but this doesn't allow for separate localizations nor for local overrides of the values. I18N normally recommends the ability to provide a local override when there is file-level metadata.

This design also suggests that some language is more privileged than all others or that large sections of the file must be repeated in order to localize the full experience described by the manifest.

@aphillips aphillips added the i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. label May 15, 2023
@tomayac
Copy link
Contributor

tomayac commented May 15, 2023

See #1045 and #676. There's a specific label already.

@tomayac tomayac closed this as completed May 15, 2023
@tomayac tomayac reopened this May 15, 2023
@tomayac
Copy link
Contributor

tomayac commented May 15, 2023

Sorry, @aphillips, realizing that this is part of a bigger i18n-needs-resolution effort. Reopening.

@aphillips
Copy link
Author

@tomayac thanks! Feel free to mark as duplicate any of the items I just filed or to link to on-going work.

@aarongustafson
Copy link
Collaborator

This is part & parcel of the translations work, no? Once we solve it for the manifest overall, it'll be solved for shortcuts. We don't need a before solution just for shortcuts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.
Projects
None yet
Development

No branches or pull requests

3 participants