Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only flat and gabled roof types #418

Open
Acknar opened this issue Nov 11, 2023 · 7 comments
Open

Only flat and gabled roof types #418

Acknar opened this issue Nov 11, 2023 · 7 comments

Comments

@Acknar
Copy link

Acknar commented Nov 11, 2023

Hi,
The addon page mentions having support for a variety of roof types and there seem to be files for them but they do not appear in the default roof type dropdown. Is this normal and how do we access these rooftypes?

Capture d’écran 2023-11-11 181853

@vvoovv
Copy link
Owner

vvoovv commented Nov 11, 2023

Those roof shapes will be created if they are contained in your OpenStreetMap extract.

@Acknar
Copy link
Author

Acknar commented Nov 12, 2023

So I need to put in different coordinates for them to appear? I looked at several locations and can't find a place that offers another roofing option. I tried major European cities as well as capitals and smaller towns in countries around the world

@vvoovv
Copy link
Owner

vvoovv commented Nov 13, 2023

The default area in the base version of the addon contains multiple roof shapes. You try it out:
12.36902,51.33,12.37983,51.33721

@Acknar
Copy link
Author

Acknar commented Nov 13, 2023

The default area has various defined rooftypes but the option for default rooftypes when none are defined remains only flat or gabled
Capture d’écran 2023-11-13 144407

@vvoovv
Copy link
Owner

vvoovv commented Nov 13, 2023

The default area has various defined rooftypes but the option for default rooftypes when none are defined remains only flat or gabled

The default roof shapes were limited to only 2 of them intentionally. It's very unlikely that all buildings have a dome or onion roof shape.

@Acknar
Copy link
Author

Acknar commented Nov 13, 2023

For these particular shapes I agree, but hipped, half-hipped, gambrel and mansard roofs are shape types that make up the majority of many European towns and cities. I am focused on Paris right now which has a very homogenous urbanism with mansard roof as the default. This roof type isn't listed in the supported roof types but at least being able to select gambrel roof as default roof type would get me closer to the intended result.

@redactedUse
Copy link

redactedUse commented Nov 20, 2023

For these particular shapes I agree, but hipped, half-hipped, gambrel and mansard roofs are shape types that make up the majority of many European towns and cities. I am focused on Paris right now which has a very homogenous urbanism with mansard roof as the default. This roof type isn't listed in the supported roof types but at least being able to select gambrel roof as default roof type would get me closer to the intended result.

in line 843 of the __init__.py of the gui directory of the plugin there is a tuple of tuples that exposes the default roof types to the GUI of the plugin.

items = (("flat", "flat", "flat shape"),("gabled", "gabled", "gabled shape"))

If you append a tuple for gambrel roof shapes like so

items = (("flat", "flat", "flat shape"),("gabled", "gabled", "gabled shape"), ("gambrel", "gambrel", "gambrel shape"))

you'll be able to select gambrel as a default roof type through the GUI. If you'd like to fork the repository or have that feature for yourself locally it's a fairly easy change to make.

Screenshot from 2023-11-20 22-51-08

Keep in mind that if you decide to expose the hipped or mansard type roofs to the GUI and select them as the default the majority of the buildings in your map will likely have flat roofs as those roof types are only supported for quadrangle building outlines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants