Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: throw error when resize option is not present #60

Open
chasegiunta opened this issue Jul 20, 2016 · 5 comments
Open

Suggestion: throw error when resize option is not present #60

chasegiunta opened this issue Jul 20, 2016 · 5 comments

Comments

@chasegiunta
Copy link

As it seems that the --resize option is a requirement (seen in my experience and #23) , maybe throw an error if the parameter is not present in command. Unless this is a bug? Gifify will continue to run indefinitely, and not create a write file in location, if not the --resize option is not defined

@vvo
Copy link
Owner

vvo commented Jul 21, 2016

Hi @chasegiunta --resize is not always needed strangely it seems. Only in some cases, would you mind digging a bit more to see why?

@chasegiunta
Copy link
Author

Unfortunately I'm not skilled enough to do so, ha. I can provide the video files (.mp4) if that is of some use.

@vvo
Copy link
Owner

vvo commented Jul 22, 2016

Yes drop them here so that someone can have a look. I have really no idea on what's going on

@chasegiunta
Copy link
Author

Apologies, it looks like it does create a temp file... But it will continue to run indefinitely (I think, I didn't leave it go to because it quickly ate up 5GB for this 7mb .mp4) https://cl.ly/0F3C2S3G1a1I

@vvo
Copy link
Owner

vvo commented Jul 25, 2016

Maybe there's an underlying bug somewhere in the dependencies stack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants