Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Cannot add 3rd party plugins to theme #470

Open
2 of 4 tasks
mateuszrusiecki opened this issue Jun 16, 2021 · 5 comments
Open
2 of 4 tasks

Cannot add 3rd party plugins to theme #470

mateuszrusiecki opened this issue Jun 16, 2021 · 5 comments
Assignees
Labels
bug Bug reports VSF1 Issues in regards to VSF1

Comments

@mateuszrusiecki
Copy link

Current behavior

According to the documentation to import 3rd party plugins I have to register it in /src/themes/default/plugins/index.js , which I have tried to do

import firebaseui from 'firebaseui';

and I get error:

ERROR in ./src/themes/default/index.js
Module not found: Error: Can't resolve 'firebaseui' in '/var/www/src/themes/default'

Expected behavior

the plugin should be registered

Steps to reproduce the issue

install firebase plugin and add the above code

Version of Vue Storefront

  • Vue Storefront
  • Vue Storefront Next

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser: Chrome 90
  • OS: MacOs Big Sur
  • Node: v15.2.1
  • VSF: 1.12.2

Additional information

It happens also for other 3rd party plugins

@mateuszrusiecki
Copy link
Author

bump

1 similar comment
@mateuszrusiecki
Copy link
Author

bump

@mateuszrusiecki
Copy link
Author

mateuszrusiecki commented Jun 18, 2021

the issue is that: when I go to src/themes/default and do
yarn add firebaseui
it adds it to package.json, but when I do
yarn install
it's not creating node_modules in src/themes/default o_O
yarn --cwd src/themes/defaul install also not creates node_modules
How I should install those dependencies then? I need to manage workspaces somehow? I have yarn 1.22, maybe I should use yarn 2?
I can use npm fot that and then it works but would be better to use yarn it whole project

@Fifciu
Copy link

Fifciu commented Jun 21, 2021

Try to add firebaseui to theme's package.json and then run yarn from the root directory.

@Fifciu Fifciu self-assigned this Jun 22, 2021
@bloodf bloodf closed this as completed Aug 20, 2021
@mateuszrusiecki
Copy link
Author

It should be add to main package.json, not to themes one

@bloodf bloodf transferred this issue from vuestorefront/vue-storefront Aug 23, 2021
@bloodf bloodf added bug Bug reports VSF1 Issues in regards to VSF1 labels Aug 23, 2021
@bloodf bloodf reopened this Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug reports VSF1 Issues in regards to VSF1
Projects
None yet
Development

No branches or pull requests

3 participants