Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Error at category page leads to 504 Gateway Time-out #469

Open
1 of 2 tasks
xkekli opened this issue May 28, 2021 · 0 comments
Open
1 of 2 tasks

Error at category page leads to 504 Gateway Time-out #469

xkekli opened this issue May 28, 2021 · 0 comments
Assignees
Labels
3: Medium complexity bug Bug reports VSF1 Issues in regards to VSF1

Comments

@xkekli
Copy link

xkekli commented May 28, 2021

Current behavior

When you have enabled alwaysSyncPlatformPricesOver in config, there is the following bug:

If your backend works with authenticated users only, an error occurs(during ssr) at line 77
https://github.com/vuestorefront/vue-storefront/blob/v1.12.2/core/modules/catalog/helpers/price/doPlatformPricesSync.ts
This is happening because no token is being sent and as a result the following code does not work
const { items } = await ProductService.getProductRenderList(...
It does not work because response is null in this scenario.

Expected behavior

I think that there should be a check if response is an object and has a key "items".

Version of Vue Storefront

  • Vue Storefront
  • Vue Storefront Next

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version: 1.12.2

Additional information

@bloodf bloodf closed this as completed Aug 20, 2021
@bloodf bloodf transferred this issue from vuestorefront/vue-storefront Aug 23, 2021
@bloodf bloodf added 3: Medium complexity bug Bug reports VSF1 Issues in regards to VSF1 labels Aug 23, 2021
@bloodf bloodf reopened this Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3: Medium complexity bug Bug reports VSF1 Issues in regards to VSF1
Projects
None yet
Development

No branches or pull requests

3 participants