Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Add Brotli compression support #354

Open
2 of 7 tasks
Fifciu opened this issue Apr 14, 2020 · 0 comments
Open
2 of 7 tasks

Add Brotli compression support #354

Fifciu opened this issue Apr 14, 2020 · 0 comments
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P3: Normal Priority mark - normal priority VSF1 Issues in regards to VSF1

Comments

@Fifciu
Copy link

Fifciu commented Apr 14, 2020

What is the motivation for adding / enhancing this feature?

Brotli compression is able to reduce file size even 29% more than GZIP. Currently, we use this package https://github.com/expressjs/compression with GZIP mode. This package has 2 PRs with Brotli support:

I think it might be a good idea to append one of those PRs and make selecting between Brotli & GZIP configurable.

What are the acceptance criteria

  • Append PR with Brotli to Compression package
  • Make it configurable to select between GZIP & Brotli

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

@bloodf bloodf closed this as completed Aug 20, 2021
@bloodf bloodf transferred this issue from vuestorefront/vue-storefront Aug 22, 2021
@bloodf bloodf added feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P3: Normal Priority mark - normal priority VSF1 Issues in regards to VSF1 labels Aug 22, 2021
@bloodf bloodf reopened this Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can P3: Normal Priority mark - normal priority VSF1 Issues in regards to VSF1
Projects
None yet
Development

No branches or pull requests

2 participants