fix: clear applied $externalResults on $model change when rules recompute #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les recompute If you're using dynamic rules object via computed as documented, your client-side validations work dynamically as expected. If you add $externalResults to the mix and the rules rules are re-computed after $externalErrors been applied, $ externalErrors are no longer cleared when $model changes. https://stackblitz.com/edit/vitejs-vite-j6ywfz?file=src%2FAppForm.vue
renatodeleao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you're using dynamic rules object via computed as documented, your client-side validations work dynamically as expected. If you add $externalResults to the mix and the rules rules are re-computed after $externalErrors been applied, $ externalErrors are no longer cleared when $model changes.
fixes #1232
Metadata
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
nextbranchfix #xxx[,#xxx], where "xxx" is the issue number)