Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating vue.volar to 2.0.17, the completionInfo can't get information successful #4368

Closed
zcf0508 opened this issue May 10, 2024 · 5 comments
Closed

Updating vue.volar to 2.0.17, the completionInfo can't get information successful #4368

zcf0508 opened this issue May 10, 2024 · 5 comments
Labels
bug Something isn't working upstream

Comments

@zcf0508
Copy link
Contributor

zcf0508 commented May 10, 2024 •
edited

Snipaste_2024-05-10_23-43-22

Snipaste_2024-05-10_23-43-38

This situation only occurs when the cursor target in setup block or setup function of defineComponent and top level identifier, like altered and start. The others like msg and data are work fine.
@zcf0508
Copy link
Contributor Author

zcf0508 commented May 11, 2024

volar 2.0.17

not work
image

work
image

@zcf0508
Copy link
Contributor Author

zcf0508 commented May 11, 2024

image

image

@zcf0508
Copy link
Contributor Author

zcf0508 commented May 11, 2024

https://github.com/volarjs/volar.js/blob/v2.2.2/packages/typescript/lib/node/decorateLanguageService.ts#L702

When there is no return of result.entries, should the result be retained?

@johnsoncodehk johnsoncodehk added bug Something isn't working upstream and removed pending triage labels May 13, 2024
@johnsoncodehk
Copy link
Member

@zcf0508 Could you try does this fixes the issue?
volar-2.0.17-patch.1.vsix.zip

@zcf0508
Copy link
Contributor Author

zcf0508 commented May 13, 2024

@zcf0508 Could you try does this fixes the issue? volar-2.0.17-patch.1.vsix.zip

It works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnsoncodehk @zcf0508