Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoOverlay and SVGOverlay #419

Open
ilyaerkhov opened this issue Jul 19, 2019 · 6 comments
Open

VideoOverlay and SVGOverlay #419

ilyaerkhov opened this issue Jul 19, 2019 · 6 comments
Labels
confirmed Issue is accepted as either a bug or a valid enhancement enhancement help wanted

Comments

@ilyaerkhov
Copy link

Hi! Can't seem to find VideoOverlay and SVGOverlay components, is it possible to access them somehow, and if not - are there any plans on adding them at some point? Thanks!

@DonNicoJs
Copy link
Member

@ilyaerkhov We do not have them for now! PR welcomed otherwise I will add them to the pipeline

@evgen904
Copy link

hi! there are no plans to output SVGOverlay method in the near future ? )
you really need, or maybe an alternative plugin will be able to advise ? )

@DonNicoJs
Copy link
Member

@evgen904 feel free to make a PR :) no, this should be part of the core repo, not a plugin, I will eventually get to it but I can't guarantee any deadline

@stale
Copy link

stale bot commented Jan 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 1, 2020
@DonNicoJs DonNicoJs added confirmed Issue is accepted as either a bug or a valid enhancement and removed wontfix labels Jan 1, 2020
@mandryllo
Copy link
Contributor

mandryllo commented Jul 21, 2021

Here are the PR’s
#683
#684

@Stealthmate
Copy link

SVG support is kind of important because right now LImageOverlay uses <img> and afaik that doesn't allow CSS styling. I used part of #684 in my own code as a quick hack, but it would be nice if this library provided the component out of the box. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Issue is accepted as either a bug or a valid enhancement enhancement help wanted
Projects
None yet
Development

No branches or pull requests

5 participants