-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component icons #69
Comments
Hey @perillosantana ! You can change all the icons used on |
Hi @matheusps, with the store-icons can I customize an icon with any svg I want? |
Yep @perillosantana . Actually you can add an entirelly new
Obs: You should not change the ID's, the store-icons use them on it's components. |
@matheusps Are you saying that is up to us to build our own icon pack and make a pull request or we can do that in our project folder without the need of a PR? |
@jpgutti , You guys use the store-theme to build your own theme, right? The |
@matheusps Awesome, thanks! |
You're welcome @jpgutti |
@matheusps As I use a new one, I saw that inside the react folder there are the files calling the Icon, so when I use the iconpack I get the id of a guy that already exists, how do I create one from zero picking up from inside my iconpack? https://github.com/vtex-apps/store-icons/blob/master/react/IconSearch.tsx |
@matheusps , this does not work to exchange icons of the native components? |
Take
The Id
And YES, your new iconpack will be used instead of the original one contained on |
@matheusps This component |
@matheusps To test replacing the hpa-hamburger-menu path for the hpa-search id path, in the component I call the Another question is, can I create an id and call with Icon? |
Expected behavior
Nowadays we do not have the option of inserting icons based on client layouts, the idea is to have the option of inserting our source icons and manipulating the component to work with our icons.
Current Behavior
the current behavior allows calling a font, but does not allow manipulating the component to insert our icon (font or img / svg), we are manipulating the element with before and after.
Context
The idea is to achieve greater precision in relation to customer layouts
The text was updated successfully, but these errors were encountered: