Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Logo Alt Text Editable #33

Open
briscoda opened this issue Dec 20, 2018 · 2 comments
Open

Make Logo Alt Text Editable #33

briscoda opened this issue Dec 20, 2018 · 2 comments

Comments

@briscoda
Copy link

Describe the bug
The logo alt text is not editable. The logo itself is, but in the source it still says "VTEX".

To Reproduce
Steps to reproduce the behavior:

  1. Go to CMS/StoreFront
  2. Click on "Header"
  3. Create Configuration for Logo
  4. You can edit logo, but not alt text

Expected behavior
I would be able to edit the logo.

Screenshots
screen shot 2018-12-20 at 10 45 04 am

Desktop (please complete the following information):

  • OS: osx 10.13
  • Browser chrome
  • Version 71
@briscoda
Copy link
Author

@brunojdo

Hi Bruno, we created small fix for this here:
https://github.com/humanelement-vtex/store-header/tree/bugs/editable-logo-alt-text-field

This already exists, but was missing from props, if you want to create fix branch against:
https://github.com/vtex-apps/store-header/tree/v1.5.1

This could be pulled in as a quick fix

@briscoda
Copy link
Author

briscoda commented Jan 4, 2019

Any update here? Wondering if this might be able to be applied or a fix branch could be created that we can suggest a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant