Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InfoCard] Button element nested inside an anchor #1068

Open
bgoyarts opened this issue Nov 25, 2022 · 0 comments
Open

[InfoCard] Button element nested inside an anchor #1068

bgoyarts opened this issue Nov 25, 2022 · 0 comments

Comments

@bgoyarts
Copy link

Describe the bug
Whenever the prop callToActionMode is set to button, a button is renderd inside an anchor tag. This button element is not valid content for an anchor element. As per documentation:

No descendant may be interactive content or an a element, and no descendant may have a specified tabindex attribute.

To Reproduce
Steps to reproduce the behavior:

  1. Add info card to your template with callToActionMode set to button
  2. Inspect the button
  3. See that it is nested inside an anchor element.

Expected behavior
The anchor should be styled as a button, or it should be a button element. But not nested.

Screenshots

Desktop (please complete the following information):
*

Smartphone (please complete the following information):
*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant