Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] som api: return person from create_person if invalid? #3

Open
vsoch opened this issue Jan 25, 2017 · 0 comments
Open

[question] som api: return person from create_person if invalid? #3

vsoch opened this issue Jan 25, 2017 · 0 comments

Comments

@vsoch
Copy link
Owner

vsoch commented Jan 25, 2017

Right now, the function "create person" creates a person object, meaning validation of the input parameters. I think it is cleanest to return None given that the data structure is not valid, and stop the response there. However, given some need to update a data structure (and assuming the client wants a function to do it) we might want to not default to this behavior (and issue a warning and return the invalid person anyway). Likely we can figure out the best option as we develop this, for now I will go with the more conservative approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant