Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scif install should return error exit code on error during appinstall #65

Open
bilke opened this issue Jan 20, 2020 · 6 comments
Open

Comments

@bilke
Copy link

bilke commented Jan 20, 2020

When something goes wrong in the %appinstall section the corresponding scif install ..-call returns 0 which means success. Would it be possible to check for errors and return a proper error value?

@vsoch
Copy link
Owner

vsoch commented Jan 20, 2020

This would definitely be wanted! Could you please provide the scif recipe / container so that I can reproduce your issue, and work on it further?

@bilke
Copy link
Author

bilke commented Jan 20, 2020

At the moment I do not have a scif recipe at hand but something like this:

...
%appinstall
return 0       # this is fine
return 1       # this should stop `scif install` and should also return maybe 1 as the `scif install`-exit code
return 0       # will not be reached in this case
....

@vsoch
Copy link
Owner

vsoch commented Jan 20, 2020

All set! #66. Would you care to test? Take a look in docs/examples, I added subfolders there (and the first is to test this use case).

@bilke
Copy link
Author

bilke commented Jan 20, 2020

Thanks a lot Vanessa! I will test thoroughly tomorrow!

@vsoch
Copy link
Owner

vsoch commented Jan 20, 2020

sounds good :) Happy MLK!

@vsoch
Copy link
Owner

vsoch commented Jan 20, 2020

Actually I'm not sure you have that holiday... so instead, how about have a good evening! And have a party too, if you feel like it 🎉 :O)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants