Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove port specification #17

Open
vsoch opened this issue Aug 1, 2018 · 2 comments
Open

remove port specification #17

vsoch opened this issue Aug 1, 2018 · 2 comments

Comments

@vsoch
Copy link
Owner

vsoch commented Aug 1, 2018

I don't see any logic for asking the user to pre-generate a custom port, and then giving an error message if/when another notebook (by the same user) is opened. It would make more sense to generate a port on the fly, and risk that another user is using it.

I'll add this tweak to my current PR.

@vsoch
Copy link
Owner Author

vsoch commented Aug 1, 2018

oh hmm, now I see that it's required to resume and end! Need to think about this. Do you have any ideas for how this could be done?

@vsoch
Copy link
Owner Author

vsoch commented Aug 1, 2018

I was thinking that the user could just specify it as an argument, but that makes usage too hard I think. For the record, if we need to generate a random port on the fly:

$ shuf -i 49152-65335 -n 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant