Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks for is_separable are not complete #518

Open
vprusso opened this issue Mar 24, 2024 · 0 comments
Open

Checks for is_separable are not complete #518

vprusso opened this issue Mar 24, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed unitaryHACK 2024

Comments

@vprusso
Copy link
Owner

vprusso commented Mar 24, 2024

Several computational conditions are checked to determine if a state is separable presently in is_separable.py. However, several items are still not covered compared to the IsSeparable function from QETLAB.

This issue covers the additional separability checks from IsSeparable and includes test cases for each condition.

Note: At present, if all other separability checks are not hit, the failsafe is the final separability check imposed by invoking the symmetric extension hierarchy. This will eventually converge and will determine whether the state is separable (however this could be computationally intractable in general, and ideally, hitting as many of the prior cases first is ideal).

With that in mind, not all separability checks from QETLAB need to be ported over, but adding some more of them into toqito would be ideal. This issue could be considered closed then if a subset of the separability checks are ported over.

@vprusso vprusso added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed unitaryHACK 2024
Projects
None yet
Development

No branches or pull requests

2 participants