Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure ruff action #512

Open
purva-thakre opened this issue Mar 14, 2024 · 1 comment
Open

Configure ruff action #512

purva-thakre opened this issue Mar 14, 2024 · 1 comment
Assignees
@purva-thakre

Comments

@purva-thakre
Copy link
Collaborator

purva-thakre commented Mar 14, 2024 •
edited

We want to allow the following to use the linter and formatted options allowed by ruff. Right now, this only checks for the linter rules.

Option 1: use ruff format . to let the github action make changes in the PR directly
Option 2: use ruff format --check to fail the workflow if there are some changes to be made by the formatted

#510 (comment)
@purva-thakre purva-thakre self-assigned this Mar 14, 2024
@purva-thakre purva-thakre mentioned this issue Mar 15, 2024
Closed
@purva-thakre
Copy link
Collaborator Author

In addition, ruff formatter configuration should be standardized. Even though we allow line-length to be <=120,
the following lines are changed by ruff as shown in the second screenshot.

image

image

@purva-thakre purva-thakre mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@purva-thakre purva-thakre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@purva-thakre