Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrueFormula and FalseFormula #2

Open
ibnyusuf opened this issue Jun 29, 2021 · 0 comments
Open

TrueFormula and FalseFormula #2

ibnyusuf opened this issue Jun 29, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ibnyusuf
Copy link
Member

In Formula.hpp we define classes TrueFormula and FalseFormula:

    class TrueFormula : public Formula
    {
        friend class Formulas;
        
    public:
        TrueFormula(std::string label = "") : Formula(label) {}
        
        Type type() const override { return Formula::Type::True; }
        std::string toSMTLIB(unsigned indentation = 0) const override;
        std::string prettyString(unsigned indentation = 0) const override;
    };
    
    class FalseFormula : public Formula
    {
        friend class Formulas;
        
    public:
        FalseFormula(std::string label = "") : Formula(label) {}
        
        Type type() const override { return Formula::Type::False; }
        std::string toSMTLIB(unsigned indentation = 0) const override;
        std::string prettyString(unsigned indentation = 0) const override;
    };

But then never use these elsewhere. Instead the function boolTrue() declared in Theory.hpp creates a predicate formula with name true. We should either remove these two classes or update Theory.hpp to make use of them.

@ibnyusuf ibnyusuf added the enhancement New feature or request label Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants