Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to use a list of Vault nodes #27

Open
voiprodrigo opened this issue Sep 4, 2020 · 3 comments
Open

[Feature Request] Ability to use a list of Vault nodes #27

voiprodrigo opened this issue Sep 4, 2020 · 3 comments

Comments

@voiprodrigo
Copy link

Hi,

It would be useful (for me at least) if lookup could use a list of node URL's, instead of a single one.
Then, in two situations it could automatically try the next node in the list:

  • in case there's no response from the node (maybe it's down or unreachable) (connection exception)
  • in case the node is sealed (response exception)

Thanks.

@igalic
Copy link

igalic commented Sep 5, 2020

if we allow vault_uri to be an Array, and allow VAULT_ADDR to be a comma separated string of addresses, then we can do something like this:
voxpupuli/puppet-jenkins#904 on connection failure, we advance to the next node in the array

would you be up for writing this patch?

@voiprodrigo
Copy link
Author

I would, yes. I'll try to open a PR soon.

@ekohl
Copy link
Member

ekohl commented Sep 6, 2020

Note that https://github.com/puppetlabs/puppet/blob/main/lib/puppet/util/retry_action.rb does exist and is probably a better approach than I took in my other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants