Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use source in gemlist #129

Closed
wants to merge 1 commit into from
Closed

Conversation

alexjfisher
Copy link
Member

When ensure => latest, gemlist is called to determine the latest
available version of a gem.

If the source parameter is a remote gem repository, this needs to be
part of the gem list command run.

Fixes #128

When `ensure => latest`, `gemlist` is called to determine the latest
available version of a gem.

If the `source` parameter is a remote gem repository, this needs to be
part of the `gem list` command run.

Fixes voxpupuli#128

Signed-off-by: Alexander Fisher <alex@linfratech.co.uk>
@alexjfisher
Copy link
Member Author

@carlossg Hi. Does this look reasonable? Thanks.

@vox-pupuli-tasks
Copy link

Dear @alexjfisher, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

2 similar comments
@vox-pupuli-tasks
Copy link

Dear @alexjfisher, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @alexjfisher, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@ekohl
Copy link
Member

ekohl commented Jul 6, 2022

@alexjfisher any plans to rebase this?

@ekohl ekohl added the bug Something isn't working label Jul 7, 2022
@alexjfisher
Copy link
Member Author

@alexjfisher any plans to rebase this?

No plans. Don't think I've used the module since 2016, so can't remember what this was all about and if it's still relevant.

@ekohl
Copy link
Member

ekohl commented Dec 16, 2022

Shall we close it then?

@alexjfisher
Copy link
Member Author

Dunno. It looks correct, and someone might want it some day. I'm not in a position to verify it still works. I could rebase it anyway?

@ekohl
Copy link
Member

ekohl commented Feb 14, 2023

Closing for now. If anyone's interested they can reopen it.

@ekohl ekohl closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge-conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using latest, gemlist method should use source parameter.
2 participants