Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using latest, gemlist method should use source parameter. #128

Open
alexjfisher opened this issue Sep 21, 2016 · 0 comments
Open

When using latest, gemlist method should use source parameter. #128

alexjfisher opened this issue Sep 21, 2016 · 0 comments

Comments

@alexjfisher
Copy link
Member

gemlist currently doesn't use the source parameter. When the gem only comes from a private gem repository, gemlist ends up returning nil and the code explodes here with

Error: Could not get latest version: undefined method `[]' for nil:NilClass

I should be able to submit a PR fixing this shortly.
alexjfisher added a commit to alexjfisher/puppet-rvm that referenced this issue Sep 21, 2016
@alexjfisher
WIP: Use source in gemlist
1177e09 
Fixes voxpupuli#128
alexjfisher added a commit to alexjfisher/puppet-rvm that referenced this issue Sep 21, 2016
@alexjfisher
Use source in gemlist
b4630db 
When `ensure => latest`, `gemlist` is called to determine the latest
available version of a gem.

If the `source` parameter is a remote gem repository, this needs to be
part of the `gem list` command run.

Fixes voxpupuli#128
@alexjfisher alexjfisher mentioned this issue Sep 21, 2016
Closed
alexjfisher added a commit to alexjfisher/puppet-rvm that referenced this issue Sep 29, 2016
@alexjfisher
Use source in gemlist
8bbe0cf 
When `ensure => latest`, `gemlist` is called to determine the latest
available version of a gem.

If the `source` parameter is a remote gem repository, this needs to be
part of the `gem list` command run.

Fixes voxpupuli#128

Signed-off-by: Alexander Fisher <alex@linfratech.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use source in gemlist alexjfisher/puppet-rvm
1 participant
@alexjfisher