Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of puppet 5 and lower artifacts #688

Closed
zilchms opened this issue Aug 14, 2023 · 2 comments · Fixed by #724
Closed

Get rid of puppet 5 and lower artifacts #688

zilchms opened this issue Aug 14, 2023 · 2 comments · Fixed by #724
Assignees

Comments

@zilchms
Copy link
Contributor

zilchms commented Aug 14, 2023

Somewhere along the line of dropping puppet 5 support, some codefragments explicitely for puppet 5 and lower have remained untouched.
One example:

if versioncmp($facts['puppetversion'],'6.1.0') < 0 {

We should find all of such instances and get rid of them.

@TheMeier TheMeier self-assigned this May 5, 2024
@TheMeier
Copy link
Contributor

TheMeier commented May 5, 2024

This is the only instance I could find.

@zilchms
Copy link
Contributor Author

zilchms commented May 5, 2024

Could very well be the only instance, just stumbled into it and thought I should keep a record on this :P

TheMeier added a commit that referenced this issue May 11, 2024
metadata.json already requires puppet >= 7

fixes #688
bastelfreak pushed a commit that referenced this issue May 18, 2024
metadata.json already requires puppet >= 7

fixes #688
bastelfreak added a commit that referenced this issue May 18, 2024
remove code for puppet < 7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants