blackbox_exporter:modules leaking sensitive info so adding no diff #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernstae
reviewed
Apr 12, 2022
There was a problem hiding this comment.
This will address the output showing plaintext passwords, so I'm in support of the change.
The only other choice would be to wrap the content attribute in a Sensitive() and change the content in the YAML ERB to use unwrap(), but I think this implementation is cleaner.
|
Are there any concerns about this? Hoping to have a maintainer weigh in. |
|
anyone looking into this, any update will be good. |
|
Can someone please review and weigh on it |
kenyon
reviewed
Jan 12, 2023
| owner => 'root', | ||
| group => $group, | ||
| mode => $config_mode, | ||
| show_diff => false, |
There was a problem hiding this comment.
IMO Sensitive support would be better. Or at least make show_diff configurable here. But I don't use this module, so 🤷
There was a problem hiding this comment.
Yes Sensitive would be better also the erb should be changed to epp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #614