issue #604 : compatibility for ssl connections to the database #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2023 12:46
e.g. azure database for mysql
smortex
reviewed
Apr 3, 2023
There was a problem hiding this comment.
Managing the system wide configuration of MySQL looks like a responsibility for the mysql module, and not this one… but it is another story.
The unit tests in spec/classes/mysqld_exporter_spec.rb do not make much sense, but can you add some for these parameters?
context 'with TLS encryted connexion to MySQL' do
let(:params) do
{
cnf_ssl_ca: '/tmp/ca.pem',
cnf_ssl_cert: '/tmp/cert.pem',
cnf_ssl_key: '/tmp/key.pem',
}
end
it { is_expected.to contain_file('/etc/.my.cnf').with_content(%r{^ssl-ca = /tmp/ca.pem$}) }
# ...
end
bastelfreak
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. azure database for mysql
Pull Request (PR) description
Added the possibility to provide ssl ca, cert and key paths for ssl connection to the database.
Due to the fact that mysqld_exporter determines this on the ssl-ca variable in exporter my cnf file, this variable is needed at least.
This Pull Request (PR) fixes the following issues
Fixes #604