Extra double quotes in env file lead to invalid syntax

[efoft]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 6.25.1
• Distribution: CentOS 7.9
• Module version: v12.2.0 (current master branch has the same problem)

What are you seeing

Invalid env file is created when installing haproxy_exporter with install_method == 'package':

ARGS="--haproxy.scrape-uri="unix:/var/lib/haproxy/stats" "

This is due to how this string is formed in the code

puppet-prometheus/manifests/haproxy_exporter.pp

Line 87 in cca7cf6

$options = "--haproxy.scrape-uri=\"${cnf_scrape_uri}\" ${extra_options}"

In /var/log/messages:
haproxy_exporter: ts=2021-12-19T00:28:14.598Z caller=haproxy_exporter.go:384 level=error msg="Can't scrape HAProxy" err="dial unix /var/lib/haproxy/stats : connect: no such file or directory"

Any additional information you'd like to impart

Once quotation is corrected like below the problem is gone

ARGS="--haproxy.scrape-uri=unix:/var/lib/haproxy/stats"

Double quotes around socket path is not requred.