Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom type within the nodejs::npm defined type #138

Open
juniorsysadmin opened this issue May 20, 2015 · 3 comments
Open

Use a custom type within the nodejs::npm defined type #138

juniorsysadmin opened this issue May 20, 2015 · 3 comments
Labels
enhancement New feature or request

Comments

@juniorsysadmin
Copy link
Member

Currently the npm defined type uses some quite ugly blocks of code. Quite apart from the fact that this could put people off eating their dinner (which is probably quite delicious), things could be a simpler and more robust if a Custom Type was used instead, with nodejs::npm simply making calls to this custom type. Ideally most of code that invokes npm should be same in both the provider and in the defined type with the exception of one or two attributes.

@igalic
Copy link
Contributor

igalic commented May 26, 2015

👍 i think i remember saying something along those lines in my innitial review of your refactor pr ;)

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Nov 16, 2015
@jyaworski
Copy link
Member

What's the status of this?

@juniorsysadmin
Copy link
Member Author

What's the status of this?

Still wanted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants