Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated su_owner parameter referenced in README.md #149

Open
synaptis opened this issue Jan 25, 2019 · 2 comments
Open

Deprecated su_owner parameter referenced in README.md #149

synaptis opened this issue Jan 25, 2019 · 2 comments

Comments

@synaptis
Copy link

Affected Puppet, Ruby, OS and module versions/distributions

  • Module version: 3.4.0

What are you seeing

README.md still refers to deprecated su_owner parameter. If used as documented manifest compilation will fail:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Logrotate::Rule[somerule]: has no parameter named 'su_owner'

What behaviour did you expect instead

README.md should contain correct information.

@Dan33l
Copy link
Member

Dan33l commented Jan 25, 2019

Hey @synaptis thank you for the report.

Can you propose a PR to fix this ? Or even better switch the module to REFERENCE.md docs ?

For instance this file https://github.com/voxpupuli/puppet-ferm/blob/master/REFERENCE.md
is produced from comments at top of pp files with a command like puppet strings generate --format markdown --out REFERENCE.md.

@lesinigo
Copy link

it's also referenced in a comment in rule.pp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants