Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Validate zone sources arguments (only support IP addresses) #325

Open
jcpunk opened this issue May 17, 2022 · 0 comments
Open

Comments

@jcpunk
Copy link
Contributor

jcpunk commented May 17, 2022

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6
  • Ruby: 2.7
  • Distribution: Fedora
  • Module version: 4.4.0

How to reproduce (e.g Puppet code you use)

  firewalld_zone { 'restricted':
    ensure           => present,
    target           => '%%REJECT%%',
    purge_rich_rules => true,
    purge_services   => true,
    purge_ports      => true,
    sources          => ['example.host.com', 'other.host.com'],
  }

What are you seeing

Firewalld rejects the hostname based source

What behaviour did you expect instead

The module would restrict the sources to Array[Stdlib::IP::Address]

Output log

Any additional information you'd like to impart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant