firewalld_rich_rule needs to autorequire firewalld_custom_service on service

[trevor-vaughan]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: All
• Ruby: All
• Distribution: All
• Module version: All

How to reproduce (e.g Puppet code you use)

This is difficult to reproduce without bricking your system but if you use firewalld::custom_service and a firewalld_service but do not explicitly chain them together, the run will fail.

What behaviour did you expect instead

Ordering should be automatic

Any additional information you'd like to impart

Adding the following to firewalld_rich_rule appears to solve the issue:

autorequire(:firewalld_custom_service) do
  self[:service]
end