Account for RedHat variants #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Hat family variants that might be used. Addresses voxpupuli#23
|
I see that #177 addresses the multiple jail.conf issue too. I could simplify this PR if that PR goes through. |
|
@decibelhertz so there's nothing left here ? |
|
Obsoleted by #177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
#23 breaks my unit testing for my company's profile class since this module fails when testing defaults against Redhta variants other than CentOS.
I suggest a simple override of OEL/Rocky/Alma/etc to use CentOS templates to reduce repeat template maintenance. Reworked hiera.yaml and
datato use modern PDK standard file, and created overrides there. Explicit testing in rspec needed similar logicThis Pull Request (PR) fixes the following issues
Fixes #23