Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporting for 'failed_nodes' doesn't work #92

Open
JoshuaSmeda opened this issue Nov 7, 2022 · 1 comment · May be fixed by #108
Open

Reporting for 'failed_nodes' doesn't work #92

JoshuaSmeda opened this issue Nov 7, 2022 · 1 comment · May be fixed by #108

Comments

@JoshuaSmeda
Copy link

If you use Catalog Diff Viewer, you might notice that there is a failed selector on custom reports (reports that are generated from Catalog Diff):

Screenshot 2022-11-07 at 15 43 35

The catalog diff face doesn't compute and write the failed_nodes and their tallies to the report file (anymore?)

The default report that gets put down, has failed_nodes set and presents correctly on the front end. You can find an example here: Catalog Diff Viewer Demo Report

I would like the failed_nodes functionality to be implemented so that I'm able to fully utilize the front end (Viewer) as intended without relying on the stdout of the Catalog Diff to know if there is an error.
@vchepkov
Copy link

I noticed the same issue. File created using output_report argument doesn't include pull_output :

  "pull_output": {
    "failed_nodes": {
  ...

@edward-harley edward-harley linked a pull request Jan 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix failed nodes report edward-harley/puppet-catalog_diff
2 participants
@vchepkov @JoshuaSmeda