Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe the same channel name with more than one callback #237

Open
jarkt opened this issue Mar 14, 2017 · 6 comments
Open

Subscribe the same channel name with more than one callback #237

jarkt opened this issue Mar 14, 2017 · 6 comments

Comments

@jarkt
Copy link

jarkt commented Mar 14, 2017

Currently the class Thruway\Role\Subscriber ignores the fact that it can be legitimate to subscribe the same channel multiple times.
https://github.com/voryx/Thruway/blob/master/src/Thruway/Role/Subscriber.php#L164

@davidwdan
Copy link
Member

@jarkt are you trying to register multiple RPCs with the same URI?

@jarkt
Copy link
Author

jarkt commented Mar 14, 2017

Sorry bad wording, I meant subscriptions.

@jarkt jarkt changed the title Register the same channel name with more than one callback Subscribe the same channel name with more than one callback Mar 14, 2017
@mbonneau
Copy link
Member

@jarkt - are you using crossbar?

@jarkt
Copy link
Author

jarkt commented Mar 14, 2017 via email

@mbonneau
Copy link
Member

@jarkt - There is an issue open here wamp-proto/wamp-proto#142 (comment)

Crossbar returns an identical subscription id if the subscription is exactly the same as an existing subscription. The Subscriber role does not currently handle this.

I will ask for clarification on the spec before figuring out which way to proceed.

@mbonneau
Copy link
Member

@jarkt - After rereading the crossbar issue, it looks like thruway should be updated to handle multiple subscriptions returning the same ids and should have an internal counter that unsubscribes when it gets down to zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants