Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing indentations #5

Open
Einstone-edge opened this issue Nov 12, 2019 · 1 comment
Open

Missing indentations #5

Einstone-edge opened this issue Nov 12, 2019 · 1 comment

Comments

@Einstone-edge
Copy link

Hi, Jie
Sorry to bother you. Your work is excellent, but I have encountered some minor problems when reading the code.
At train.py in codes document, when defining generate_input_long_history2, there may be missing an indentation at every line from 145 to 154.

@gunarto90
Copy link

I agree but I think it is not only from 145 to 154 but it is from 145 to 159 because it is quite strange that the variable "i" is referred but it is not inside a loop. If it is designed like that, can the author verify the logic of it? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants