Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variable to enable/disable JS challenge #23

Open
madhukar32 opened this issue Apr 23, 2021 · 2 comments
Open

Add a variable to enable/disable JS challenge #23

madhukar32 opened this issue Apr 23, 2021 · 2 comments
Assignees

Comments

@madhukar32
Copy link
Collaborator

Add a variable to enable/disable JS challenge

@cohenaj194
Copy link
Collaborator

@cohenaj194
Copy link
Collaborator

cohenaj194 commented May 3, 2021

The main and staging 0.4.0-rc2 branches has been updated to include the changes.

I am seeing an issue in AC with the use of this new disable_js_challenge var:

$ terraform apply -var-file=demo.tfvars.json -auto-approve
Error: Unsupported argument
  on main.tf line 6, in module "app-delivery-network":
   6:   disable_js_challenge = var.disable_js_challenge
An argument named "disable_js_challenge" is not expected here.
ERROR: Job failed: command terminated with exit code 1

This was present in both prod and staging until I merged the changes from main into the 0.4.0-rc2 branch. I suspect that production is not automatically using the latest commit of the main branch. @madhukar32 tomorrow let's look into this so that we ensure the latest changes from main are automatically available to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants